More robust 'Name' field parsing in SeriesMgr Excel input#103
Open
kimble4 wants to merge 6 commits intoesitarski:devfrom
Open
More robust 'Name' field parsing in SeriesMgr Excel input#103kimble4 wants to merge 6 commits intoesitarski:devfrom
kimble4 wants to merge 6 commits intoesitarski:devfrom
Conversation
If there is only a 'Name' field, and the contents aren't comma-separated, split on the last space in the name if there is one, or failing that, treat the entire thing as LastName. A minor convenience for working with Excel files that have come from somewhere other than CrossMgr. This also allows SeriesMgr to reliably read its own Excel output, where the names aren't always comma-separated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If there is only a 'Name' field, and the contents aren't comma-separated, split on the last space in the name if there is one, or failing that, treat the entire thing as LastName.
A minor convenience for working with Excel files that have come from somewhere other than CrossMgr.
This also allows SeriesMgr to reliably read its own Excel output, where the names aren't always comma-separated.